Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ash-window: Upgrade to raw-window-handle 0.6.0 #799

Merged
merged 2 commits into from
Mar 24, 2024
Merged

ash-window: Upgrade to raw-window-handle 0.6.0 #799

merged 2 commits into from
Mar 24, 2024

Conversation

MarijnS95
Copy link
Collaborator

This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we can even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements:

  • Upgrade raw-window-metal via #8 (Mac/iOS wasn't tested in our CI);
  • Fix Windows platform types (in the ash crate) to be isize instead of *const c_void, matching the usptream definition;
  • Update example code (impossible until winit with raw-window-handle 0.6 becomes available).

@MarijnS95 MarijnS95 force-pushed the rwh-0.6 branch 2 times, most recently from 7bd707d to 5fcf4da Compare October 18, 2023 17:38
@Ralith
Copy link
Collaborator

Ralith commented Oct 21, 2023

winit 0.29 w/ rwh 0.6 is now out.

For anybody refreshing this issue, note that winit 0.29 still has a cargo feature for rwh 0.5 support, so this shouldn't block anyone.

@ilyas-taouaou
Copy link

yep winit now uses 0.6

@MarijnS95
Copy link
Collaborator Author

I'm subscribed to the releases after being involved with the ndk/Android portion of the release process 😉

@ilyas-taouaou
Copy link

thanks, when do you think would this be pushed?

@SkillerRaptor
Copy link

Any updates on this PR?

@dvtkrlbs
Copy link

dvtkrlbs commented Nov 4, 2023

I am open to testing for macos and ios tomorrow.

@HugoPeters1024
Copy link
Contributor

For what it's worth. This works on Ubuntu 22.04 on my vulkan backend for bevy after updating to bevy 0.13 (which in turn uses the new winit that depends on rwh-0.6).

@Skareeg
Copy link

Skareeg commented Feb 21, 2024

I must admit my agreeance with the comment from #864 that RWH 0.6 might be overengineering a little, but I will admit a focus on safety is fine. I am using the feature to downgrade to RWH 0.5 on a personal project but would like to +1 this pull request. If there is anything I can do to assist, let me know.

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from one nit.

ash-window/src/lib.rs Outdated Show resolved Hide resolved
ash-window/src/lib.rs Outdated Show resolved Hide resolved
This is the successor to #795.  While it doesn't tackle things like
backwards-compatibility nor use of the new lifetimed handles (if we _can_
even come up with a safe abstraction for them - it's very likely out of
scope!), it includes the following improvements:

- Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI);
- Fix Windows platform types (in the `ash` crate) to be `isize` instead
  of `*const c_void`, matching the usptream definition;
- Update example code (impossible until `winit` with `raw-window-handle
  0.6` becomes available).

[#8]: rust-windowing/raw-window-metal#8
@MarijnS95 MarijnS95 merged commit 9d225c5 into master Mar 24, 2024
20 checks passed
@MarijnS95 MarijnS95 deleted the rwh-0.6 branch March 24, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants