-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename internal function asdf_tool_versions_filename
#1544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Though I would like a better PR title.
@Stratus3D are you happy with these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is annoying, but can we have two PRs for these changes.
One with the rename, the other with the improved nullglob change?
The PR titles end up in the Changelog so we would ideally like PRs with one change so we can name the PRs and therefore changelog better.
5fc8d94
to
e5b6b0b
Compare
asdf_default_tool_versions_filename
asdf_default_tool_versions_filename
asdf_tool_versions_filename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks mate!
Looks good to me! |
Summary
Applied suggestions from here and here.