Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sf #124

Merged
merged 299 commits into from
Mar 22, 2023
Merged
Changes from 2 commits
Commits
Show all changes
299 commits
Select commit Hold shift + click to select a range
3be0f60
Remove test data.
benjaminrwilson Mar 14, 2023
0be4d6d
Remove pandas stubs.
benjaminrwilson Mar 14, 2023
fcbd2f1
Add docstrings.
benjaminrwilson Mar 14, 2023
07140a0
Add docstrings.
benjaminrwilson Mar 14, 2023
de6ba7a
Reorganize files.
benjaminrwilson Mar 14, 2023
8e50166
Cleanup dataloader get method.
benjaminrwilson Mar 14, 2023
9e30925
Minor fixes on docstrings.
benjaminrwilson Mar 14, 2023
9df40e0
Fix args ordering.
benjaminrwilson Mar 14, 2023
688c4b1
Add additional comments.
benjaminrwilson Mar 14, 2023
3f6848c
Update docstring.
benjaminrwilson Mar 14, 2023
02d6804
Add image deps.
benjaminrwilson Mar 14, 2023
e2848c3
Update arg.
benjaminrwilson Mar 14, 2023
1e02e33
Update readmes.
benjaminrwilson Mar 14, 2023
c6146d1
Add additional readme + remove unused code.
benjaminrwilson Mar 14, 2023
a51e369
Fix lint.
benjaminrwilson Mar 14, 2023
e6d1a97
Add option type for annotations.
benjaminrwilson Mar 14, 2023
afe0cf7
Remove hard-coded mmap.
benjaminrwilson Mar 14, 2023
19384c9
Update readmes.
benjaminrwilson Mar 14, 2023
5c560bd
Update torch init.
benjaminrwilson Mar 14, 2023
07b7eff
Fix utils shapes.
benjaminrwilson Mar 15, 2023
e5fea8a
Update typing.
benjaminrwilson Mar 15, 2023
2309934
Modify docstring.
benjaminrwilson Mar 15, 2023
9baffc6
Update utils.py
benjaminrwilson Mar 15, 2023
22cd423
added scene flow extension to the API
nchodosh Mar 17, 2023
c618359
Add maximize build space.
benjaminrwilson Mar 17, 2023
fdf6ae0
Merge branch 'feature/rust' of https://github.com/argoverse/av2-api i…
benjaminrwilson Mar 17, 2023
60333d1
fix type and linter errors
nchodosh Mar 17, 2023
f7dbea8
black and isort
nchodosh Mar 17, 2023
027b21a
Comment out torch temporarily.
benjaminrwilson Mar 17, 2023
242c6aa
added docstring
nchodosh Mar 17, 2023
455baca
Restructure torch dataloader.
benjaminrwilson Mar 17, 2023
6344744
Update ci.
benjaminrwilson Mar 17, 2023
c37f2f4
Update ci.
benjaminrwilson Mar 17, 2023
934d2d2
a lot of docstrings
nchodosh Mar 17, 2023
7271263
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 18, 2023
3097d22
isort and black
nchodosh Mar 18, 2023
72c7584
detaching
nchodosh Mar 18, 2023
4fc003c
fix
nchodosh Mar 18, 2023
e871cab
detach
nchodosh Mar 18, 2023
5e64759
bugfix and got rid of gradients on return values
nchodosh Mar 18, 2023
f62cb09
Remove explicit final types.
benjaminrwilson Mar 18, 2023
8521212
PR changes
nchodosh Mar 18, 2023
700bfdf
Update src/av2/torch/dataloaders/utils.py
nchodosh Mar 18, 2023
18d4bc4
Update src/av2/evaluation/scene_flow/make_submission_archive.py
nchodosh Mar 18, 2023
4d5c95b
more PR changes
nchodosh Mar 19, 2023
2470b77
Merge branch 'feature/sf' of github.com:argoverse/av2-api-sf into fea…
nchodosh Mar 19, 2023
7a41322
Update src/av2/evaluation/scene_flow/constants.py
nchodosh Mar 19, 2023
6509e6c
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
e1cd918
Update src/av2/evaluation/scene_flow/constants.py
nchodosh Mar 19, 2023
7df2ab1
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
f1d1ad2
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
9820bd5
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
1d20e84
Update src/av2/evaluation/scene_flow/constants.py
nchodosh Mar 19, 2023
5a7e38c
Update src/av2/evaluation/scene_flow/constants.py
nchodosh Mar 19, 2023
327100b
Update src/av2/evaluation/scene_flow/constants.py
nchodosh Mar 19, 2023
1ed3b76
Update src/av2/evaluation/scene_flow/constants.py
nchodosh Mar 19, 2023
71a645a
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
72dff62
more formatting
nchodosh Mar 19, 2023
f82c083
Update object types.
benjaminrwilson Mar 19, 2023
e6d1d78
Docstring improvements.
benjaminrwilson Mar 19, 2023
3468101
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
bf1ef2a
Update dataloader helpers.
benjaminrwilson Mar 19, 2023
06232ec
got rid of annotation category duplicates
nchodosh Mar 19, 2023
efaa0fc
Merge branch 'feature/sf' of github.com:argoverse/av2-api-sf into fea…
nchodosh Mar 19, 2023
708caf6
Update dataloader helpers.
benjaminrwilson Mar 19, 2023
b5ab938
Minor updates on cuboids.
benjaminrwilson Mar 19, 2023
65483d5
Update detection dataloader + rust nits.
benjaminrwilson Mar 19, 2023
e349699
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 19, 2023
5d2211f
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 19, 2023
d052631
updates for cuboids
nchodosh Mar 19, 2023
d5c0d82
logical or
nchodosh Mar 19, 2023
33023da
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 19, 2023
36e139a
PR requests
nchodosh Mar 19, 2023
cb8bcd8
Fix lint.
benjaminrwilson Mar 19, 2023
012c571
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 19, 2023
46f9018
lint
nchodosh Mar 19, 2023
4b836c9
Fix typing.
benjaminrwilson Mar 19, 2023
34a60a9
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 19, 2023
3d0ff7c
Fix docstrings.
benjaminrwilson Mar 19, 2023
b9854eb
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
d6627f0
Update src/av2/torch/dataloaders/utils.py
nchodosh Mar 19, 2023
2c5bbe1
Update column naming.
benjaminrwilson Mar 19, 2023
ca5936d
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
3cf5118
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
134580c
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
0040d1d
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
645eabb
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
5735148
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
b2913fa
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
aea2131
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
90a2207
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
e31e672
more PR requests
nchodosh Mar 19, 2023
21823bb
Merge branch 'feature/sf' of github.com:argoverse/av2-api-sf into fea…
nchodosh Mar 19, 2023
3f64f01
Add additional examples.
benjaminrwilson Mar 19, 2023
fe821f1
Merge branch 'feature/sf' of github.com:argoverse/av2-api-sf into fea…
nchodosh Mar 19, 2023
ab15457
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 19, 2023
8740374
Add additional examples.
benjaminrwilson Mar 19, 2023
7dc3ef2
typing woes
nchodosh Mar 19, 2023
1df5b6d
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 19, 2023
013d10e
typing fixes
nchodosh Mar 19, 2023
56e4b23
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
93f5dfd
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
de25371
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
a1ac102
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
8c9bbe3
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
72bfdd2
Update src/av2/evaluation/scene_flow/constants.py
nchodosh Mar 19, 2023
6173fe7
Update src/av2/evaluation/scene_flow/constants.py
nchodosh Mar 19, 2023
9715004
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
074bd34
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
5d0293c
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
d786a2e
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
61dcb95
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
af18853
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
c14ed64
Update src/av2/evaluation/scene_flow/utils.py
nchodosh Mar 19, 2023
446f03b
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 19, 2023
bcf2162
Update src/av2/evaluation/scene_flow/constants.py
nchodosh Mar 19, 2023
ee51df8
Update torch structures.
benjaminrwilson Mar 19, 2023
d2feca1
Update se3.rs
benjaminrwilson Mar 19, 2023
5050c74
formatting
nchodosh Mar 19, 2023
e721309
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 19, 2023
6882596
Add unit tests.
benjaminrwilson Mar 19, 2023
98315a0
Merge branch 'feature/rust' of https://github.com/argoverse/av2-api i…
benjaminrwilson Mar 19, 2023
a6924ed
Add additional tests.
benjaminrwilson Mar 19, 2023
4728336
Update naming.
benjaminrwilson Mar 19, 2023
9df5c5c
Update rust vars.
benjaminrwilson Mar 19, 2023
e3bb48a
Update naming.
benjaminrwilson Mar 19, 2023
2a91e43
Fix nit
benjaminrwilson Mar 19, 2023
f9b020f
Fix docstring.
benjaminrwilson Mar 19, 2023
55915ae
Fix docstring.
benjaminrwilson Mar 19, 2023
5a8d024
Fix enum.
benjaminrwilson Mar 19, 2023
502842f
Add utils tests.
benjaminrwilson Mar 19, 2023
3fd3a31
Update README.md
benjaminrwilson Mar 19, 2023
28fa6f1
Add additional tests.
benjaminrwilson Mar 19, 2023
aaffaae
Remove dead code.
benjaminrwilson Mar 19, 2023
bec2fee
Merge branch 'feature/rust' of https://github.com/argoverse/av2-api i…
benjaminrwilson Mar 19, 2023
b1eb02b
Update spelling.
benjaminrwilson Mar 19, 2023
7d08883
Update docstrings.
benjaminrwilson Mar 19, 2023
96aae61
Add additional examples.
benjaminrwilson Mar 19, 2023
663e80c
Remove unused import.
benjaminrwilson Mar 19, 2023
b2d9a47
Update versioning.
benjaminrwilson Mar 19, 2023
a5b9bac
Rename rust methods.
benjaminrwilson Mar 19, 2023
50d395f
Update docstrings.
benjaminrwilson Mar 19, 2023
82687cf
Update sweep variables.
benjaminrwilson Mar 19, 2023
1b76576
Minor docstring updates.
benjaminrwilson Mar 19, 2023
02ee74b
Add rust warning.
benjaminrwilson Mar 19, 2023
19b5854
Minor docstring updates.
benjaminrwilson Mar 19, 2023
ca24f4f
Add init files to test.
benjaminrwilson Mar 20, 2023
1529b73
tests!
nchodosh Mar 20, 2023
c1dcc72
appease mypy
nchodosh Mar 20, 2023
86843ab
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 20, 2023
65c9176
Update scene flow.
benjaminrwilson Mar 20, 2023
d087d77
more merging
nchodosh Mar 20, 2023
1eb12b9
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 20, 2023
c3f66f2
Add docstrings + change assert_allclose.
benjaminrwilson Mar 20, 2023
11a91a9
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 20, 2023
5547089
removed my fix
nchodosh Mar 20, 2023
093faa3
Testing fixes.
benjaminrwilson Mar 20, 2023
21ecd26
maybe fix test?
nchodosh Mar 20, 2023
a3d2de6
Merge branch 'feature/rust' into feature/sf
nchodosh Mar 20, 2023
0072a37
forgot to numpy
nchodosh Mar 20, 2023
4625b3d
strange ci stuff
nchodosh Mar 20, 2023
17d8ee1
weirder CI stuff
nchodosh Mar 20, 2023
761efb7
Merge branch 'main' into feature/sf
nchodosh Mar 20, 2023
d7f62d6
error message
nchodosh Mar 20, 2023
0bceca9
test update
nchodosh Mar 20, 2023
c8b9750
make mask script
nchodosh Mar 20, 2023
a2307ec
fp is not accurate
nchodosh Mar 20, 2023
918a2cd
change evaluation mask
nchodosh Mar 20, 2023
31072e0
formatting
nchodosh Mar 20, 2023
473d16d
Update tests/evaluation/scene_flow/test_sf_eval.py
nchodosh Mar 20, 2023
d4168f9
Update src/av2/torch/structures/sweep.py
nchodosh Mar 20, 2023
2e1fc49
Update src/av2/torch/structures/flow.py
nchodosh Mar 20, 2023
6e897fd
Update src/av2/torch/data_loaders/scene_flow.py
nchodosh Mar 20, 2023
13ee1a9
Update src/av2/evaluation/scene_flow/utils.py
nchodosh Mar 20, 2023
8c1d523
Update src/av2/evaluation/scene_flow/make_annotation_files.py
nchodosh Mar 20, 2023
39c6b9f
Update src/av2/evaluation/scene_flow/make_annotation_files.py
nchodosh Mar 20, 2023
52b85b7
Update src/av2/evaluation/scene_flow/make_annotation_files.py
nchodosh Mar 20, 2023
385ccda
Update src/av2/evaluation/scene_flow/make_annotation_files.py
nchodosh Mar 20, 2023
13a40aa
Update src/av2/evaluation/scene_flow/constants.py
nchodosh Mar 20, 2023
a2d2f21
formating
nchodosh Mar 20, 2023
36bc06f
Update src/av2/evaluation/scene_flow/constants.py
nchodosh Mar 20, 2023
1afb338
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 20, 2023
e3daf0c
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 20, 2023
1a91fe2
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 20, 2023
7c47391
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 20, 2023
e5a2170
Update src/av2/evaluation/scene_flow/example_submission.py
nchodosh Mar 20, 2023
255cedc
more formatting
nchodosh Mar 20, 2023
a43048c
convert to list for pd indexing
nchodosh Mar 20, 2023
4ed5055
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 20, 2023
257a3f5
Update src/av2/evaluation/scene_flow/SUBMISSION_FORMAT.md
nchodosh Mar 20, 2023
1b46764
Update src/av2/evaluation/scene_flow/SUBMISSION_FORMAT.md
nchodosh Mar 20, 2023
d59c0d9
Update src/av2/evaluation/scene_flow/SUBMISSION_FORMAT.md
nchodosh Mar 20, 2023
1716d11
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 20, 2023
35485af
moving lists to enums and more constants
nchodosh Mar 20, 2023
4b90ba2
added eval masks for validation split
nchodosh Mar 20, 2023
2d77925
allow making validation annotation files
nchodosh Mar 20, 2023
8e17294
avoid data_loader refusal to read test annotation
nchodosh Mar 20, 2023
15117ee
updated submission formats
nchodosh Mar 21, 2023
d676a7e
Update src/av2/evaluation/scene_flow/constants.py
nchodosh Mar 21, 2023
f79c849
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 21, 2023
69e7050
Update src/av2/torch/data_loaders/scene_flow.py
nchodosh Mar 21, 2023
3fd2c12
Update src/av2/torch/structures/flow.py
nchodosh Mar 21, 2023
c98f10f
Update src/av2/torch/structures/flow.py
nchodosh Mar 21, 2023
db8910b
more enums and better names
nchodosh Mar 21, 2023
c99fcb6
Update src/av2/evaluation/scene_flow/SUBMISSION_FORMAT.md
nchodosh Mar 21, 2023
7f6021b
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 21, 2023
94491d8
Update src/av2/evaluation/scene_flow/eval.py
nchodosh Mar 21, 2023
9e2e869
Apply suggestions from code review
nchodosh Mar 21, 2023
bf467a8
torch not numpy
nchodosh Mar 21, 2023
01e6d95
Merge branch 'feature/sf' of github.com:argoverse/av2-api-sf into fea…
nchodosh Mar 21, 2023
9c226a4
formatting
nchodosh Mar 21, 2023
8254777
Apply suggestions from code review
nchodosh Mar 21, 2023
b3c4da8
formatting
nchodosh Mar 21, 2023
3c8d56f
Merge branch 'feature/sf' of github.com:argoverse/av2-api-sf into fea…
nchodosh Mar 21, 2023
fc895e4
alphabetical order
nchodosh Mar 21, 2023
0113a98
Apply suggestions from code review
nchodosh Mar 21, 2023
d5953e2
starting convert
nchodosh Mar 21, 2023
2035180
fixed script
Mar 21, 2023
c7025a9
done conversion
nchodosh Mar 21, 2023
64f3143
Use autoflake to remove unused imports.
benjaminrwilson Mar 21, 2023
d1ad243
starting
nchodosh Mar 21, 2023
666823f
todos
nchodosh Mar 21, 2023
f155a3b
Refactor variables + remove unused.
benjaminrwilson Mar 21, 2023
feac0ba
starting
nchodosh Mar 21, 2023
9c788f3
Update compute_accuracy and compute_angle_error.
benjaminrwilson Mar 21, 2023
6da885c
Update SUBMISSION_FORMAT.md
benjaminrwilson Mar 21, 2023
2c03b4a
refactor compute_metrics
nchodosh Mar 21, 2023
8e0530e
Merge branch 'feature/sf' of github.com:argoverse/av2-api-sf into fea…
nchodosh Mar 21, 2023
678eb8b
Merge branch 'feature/sf' into auto-sf-labels
nchodosh Mar 21, 2023
f0376aa
Apply suggestions from code review
nchodosh Mar 21, 2023
bcc8463
working
nchodosh Mar 21, 2023
2a9143e
Apply PR suggestions
nchodosh Mar 21, 2023
1c25325
Merge branch 'feature/sf' into auto-sf-labels
nchodosh Mar 21, 2023
6f43d54
Apply suggestions from code review
nchodosh Mar 21, 2023
bcc520a
closer
nchodosh Mar 21, 2023
0f3a680
more refactoring
nchodosh Mar 21, 2023
74e5bdf
Merge branch 'feature/sf' into auto-sf-labels
nchodosh Mar 21, 2023
00fa21c
Apply suggestions from code review
nchodosh Mar 21, 2023
91c256a
making tests
nchodosh Mar 21, 2023
7f52be1
PR suggestions
nchodosh Mar 21, 2023
4a1d6b6
finished
nchodosh Mar 21, 2023
da979ec
Merge branch 'auto-sf-labels' into feature/sf
nchodosh Mar 21, 2023
dc014a4
deleted unused format files
nchodosh Mar 21, 2023
6a4e8d8
Fix circular import.
benjaminrwilson Mar 21, 2023
1c0db1a
Update src/av2/torch/structures/flow.py
benjaminrwilson Mar 21, 2023
fd12cd3
Update src/av2/torch/structures/flow.py
nchodosh Mar 21, 2023
b9d50be
Fix circular import.
benjaminrwilson Mar 21, 2023
cc02801
Merge branch 'feature/sf' of https://github.com/argoverse/av2-api-sf …
benjaminrwilson Mar 21, 2023
d075f35
Fix line length.
benjaminrwilson Mar 21, 2023
fddfa63
formatting
nchodosh Mar 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/av2/evaluation/detection/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import logging
from dataclasses import dataclass
from pathlib import Path
from typing import Dict, List, Optional, Tuple, Union, cast
from typing import Dict, List, Optional, Tuple, Union

import numpy as np
from joblib import Parallel, delayed
Expand Down Expand Up @@ -316,7 +316,7 @@ def compute_average_precision(
# Evaluate precision at different recalls.
precision_interpolated: NDArrayFloat = np.interp(recall_interpolated, recall, precision, right=0)

average_precision: float = cast(float, np.mean(precision_interpolated))
average_precision = np.mean(precision_interpolated).astype(float)
return average_precision, precision_interpolated


Expand Down