Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sf #124

Merged
merged 299 commits into from
Mar 22, 2023
Merged

Feature/sf #124

merged 299 commits into from
Mar 22, 2023

Conversation

nchodosh
Copy link
Contributor

@nchodosh nchodosh commented Mar 20, 2023 •
edited
Loading

PR Summary

Added an extension to the API to compute scene-flow pseudo labels and added utilities for submitting to the CVPR challenge.

Testing

Everything that is factored into methods has unit test coverage. That leaves out some argument parsing code in scripts.

In order to ensure this PR works as intended, it is:

  • unit tested.
  • other or not applicable (additional detail/rationale required)

Compliance with Standards

As the author, I certify that this PR conforms to the following standards:

  • Code changes conform to PEP8 and docstrings conform to the Google Python style guide.
  • A well-written summary explains what was done and why it was done.
  • The PR is adequately tested and the testing details and links to external results are included.

benjaminrwilson and others added 30 commits March 13, 2023 18:57
@benjaminrwilson
Remove test data.
3be0f60
@benjaminrwilson
Remove pandas stubs.
0be4d6d
@benjaminrwilson
Add docstrings.
fcbd2f1
@benjaminrwilson
Add docstrings.
07140a0
@benjaminrwilson
Reorganize files.
de6ba7a
@benjaminrwilson
Cleanup dataloader get method.
8e50166
@benjaminrwilson
Minor fixes on docstrings.
9e30925
@benjaminrwilson
Fix args ordering.
9df40e0
@benjaminrwilson
Add additional comments.
688c4b1
@benjaminrwilson
Update docstring.
3f6848c
@benjaminrwilson
Add image deps.
02d6804
@benjaminrwilson
Update arg.
e2848c3
@benjaminrwilson
Update readmes.
1e02e33
@benjaminrwilson
Add additional readme + remove unused code.
c6146d1
@benjaminrwilson
Fix lint.
a51e369
@benjaminrwilson
Add option type for annotations.
e6d1a97
@benjaminrwilson
Remove hard-coded mmap.
afe0cf7
@benjaminrwilson
Update readmes.
19384c9
@benjaminrwilson
Update torch init.
5c560bd
@benjaminrwilson
Fix utils shapes.
07b7eff
@benjaminrwilson
Update typing.
e5fea8a
@benjaminrwilson
Modify docstring.
2309934
@benjaminrwilson
Update utils.py
9baffc6 
Remove cast.
@nchodosh
added scene flow extension to the API
22cd423
@benjaminrwilson
Add maximize build space.
c618359
@benjaminrwilson
Merge branch 'feature/rust' of https://github.com/argoverse/av2-api i…
fdf6ae0 
…nto feature/rust
@nchodosh
fix type and linter errors
60333d1
@nchodosh
black and isort
f7dbea8
@benjaminrwilson
Comment out torch temporarily.
027b21a
@nchodosh
added docstring
242c6aa
benjaminrwilson
benjaminrwilson requested changes Mar 21, 2023
View reviewed changes
src/av2/evaluation/scene_flow/eval.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/eval.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/eval.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/eval.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/example_submission.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/make_annotation_files.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/make_annotation_files.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/make_annotation_files.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/make_submission_archive.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/make_submission_archive.py Outdated Show resolved Hide resolved
benjaminrwilson
benjaminrwilson requested changes Mar 21, 2023
View reviewed changes
src/av2/evaluation/scene_flow/eval.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/eval.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/eval.py Outdated Show resolved Hide resolved
src/av2/torch/structures/flow.py Outdated Show resolved Hide resolved
benjaminrwilson
benjaminrwilson requested changes Mar 21, 2023
View reviewed changes
src/av2/evaluation/scene_flow/utils.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/utils.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/utils.py Outdated Show resolved Hide resolved
src/av2/evaluation/scene_flow/utils.py Outdated Show resolved Hide resolved
src/av2/torch/structures/flow.py Outdated Show resolved Hide resolved
@benjaminrwilson benjaminrwilson merged commit 27d3b40 into argoverse:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminrwilson benjaminrwilson benjaminrwilson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nchodosh @benjaminrwilson