Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: align backend response status with UI #4433

Merged
merged 9 commits into from
Dec 22, 2023

Conversation

frascuchon
Copy link
Member

Description

After changes introduced in #4346, the pending status represents exactly what the missing status is. This PR deprecates the missing status for record responses in favor of a new pending status.

@damianpumar, maybe you can adat the changes in the frontend part.

Refs: #4346

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 19, 2023
@frascuchon frascuchon self-assigned this Dec 19, 2023
@dosubot dosubot bot added area: server Indicates that an issue or pull request is related to the server language: python Pull requests or issues that update Python code status: invalid Indicates that an issue or pull request is no longer relevant team: backend Indicates that the issue or pull request is owned by the backend team type: refactor Indicates internal refactoring of the code-base labels Dec 19, 2023
@frascuchon frascuchon force-pushed the refactor/align-backend-response-status-with-UI branch from a122411 to cfc5a07 Compare December 19, 2023 16:01
CHANGELOG.md Outdated Show resolved Hide resolved
@jfcalvo
Copy link
Member

jfcalvo commented Dec 19, 2023

Is not possible to do a data migration updating old missing to pending so we can remove the old code?

Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4433-ki24f765kq-no.a.run.app

@damianpumar
Copy link
Contributor

Hi Team!
Yes, for sure is necessary to align the frontend with backend. @frascuchon do you need to do the change now?
FYI: It would be no more than 15 minutes. Just let me know and add my commit here.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6630d7b) 90.13% compared to head (b1e8987) 91.33%.
Report is 552 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4433      +/-   ##
===========================================
+ Coverage    90.13%   91.33%   +1.19%     
===========================================
  Files          233      335     +102     
  Lines        12493    19326    +6833     
===========================================
+ Hits         11261    17651    +6390     
- Misses        1232     1675     +443     
Flag Coverage Δ
pytest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damianpumar
Copy link
Contributor

Hi guys! the CI is not working due to some failed tests, could you take a look?

@frascuchon
Copy link
Member Author

Is not possible to do a data migration updating old missing to pending so we can remove the old code?

The missing status is not stored in the DB, since reflects the status when a record has no response. So, there is no need for a migration definition. Anyway, we must keep backward compatibility with 2 versions behind, letting client users adapt to the new change, so old code cannot be removed with these changes.

CHANGELOG.md Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 20, 2023
@frascuchon frascuchon merged commit 3b524d6 into develop Dec 22, 2023
2 of 3 checks passed
@frascuchon frascuchon deleted the refactor/align-backend-response-status-with-UI branch December 22, 2023 11:41
@frascuchon frascuchon added this to the v1.22.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: server Indicates that an issue or pull request is related to the server language: python Pull requests or issues that update Python code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. status: invalid Indicates that an issue or pull request is no longer relevant team: backend Indicates that the issue or pull request is owned by the backend team type: refactor Indicates internal refactoring of the code-base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants