-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Review server app setup #4432
Conversation
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4432-ki24f765kq-no.a.run.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4432 +/- ##
===========================================
+ Coverage 90.13% 91.32% +1.18%
===========================================
Files 233 334 +101
Lines 12493 19315 +6822
===========================================
+ Hits 11261 17640 +6379
- Misses 1232 1675 +443
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
max_time=60, | ||
on_backoff=_on_backoff, | ||
) | ||
def _setup_elasticsearch(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should have a similar a similar function for Redis that do a ping
to Redis (not here in your PR, I mean in my PR #4427) so we now early if Redis is not available, showing an error message.
Description
In this PR the
argilla.server.server
module has been removed and all server application setup has been moved to theargilla.server.app
module.Also, all the app creation flow has been wrapped into the
create_server_app
functionType of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Running locally `python -m argilla server start``
Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)