Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: argilla-io/argilla
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.13.0
Choose a base ref
...
head repository: argilla-io/argilla
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.13.1
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Jul 21, 2023

  1. fix: Remove type creation for postgresql (#3438) 

    <!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

The last alembic migration definitions fail when using PostgreSQL as the
database. This PR fixes this by allowing upgrade and downgrade properly.
For more info about the problem, see here
sqlalchemy/alembic#886


**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [X] Bug fix (non-breaking change which fixes an issue)

**How Has This Been Tested**

Changes have been tested using a local database to apply migrations
(update and downgrade)

**Checklist**

- [ ] I added relevant documentation
- [ ] follows the style guidelines of this project
- [ ] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: Francisco Aranda <[email protected]>
    @frascuchon
    frascuchon and Francisco Aranda committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    6ca128f View commit details
    Browse the repository at this point in the history

  2. chore: Set release version

    Francisco Aranda committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    8ac9650 View commit details
    Browse the repository at this point in the history
Loading