Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install location of icudtl.dat #279

Closed
jwinarske opened this issue Aug 24, 2022 · 5 comments
Closed

install location of icudtl.dat #279

jwinarske opened this issue Aug 24, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@jwinarske
Copy link
Contributor

icudtl.dat is not a system library, is generally unique to an application, and really shouldn't be installed in /usr/lib/.

In meta-flutter I install icudtl.dat to /usr/share/flutter. This is shared between users, and specific to flutter.

@DoumanAsh
Copy link
Contributor

With this commit you can put it inside bundle together with engine so it no longer requires system installation and allows to tie it to application.

I'm not sure it is wise to do anything else as this file probably compatible only with particular flutter versions

@ardera
Copy link
Owner

ardera commented Aug 25, 2022

@DoumanAsh true, I think bundling it with the app is even better, but since most people do install engine system-wide, we might as well install the icudtl system-wide as well.

@jwinarske Loading it from /usr/share/flutter is fine. I didn't really think about it too much when I put it inside /usr/lib. I'll prepare a PR and change the engine-binaries installer so it installs to /usr/share/flutter.

@ardera ardera self-assigned this Aug 25, 2022
@ardera ardera added the enhancement New feature or request label Aug 25, 2022
@jwinarske
Copy link
Contributor Author

jwinarske commented Aug 25, 2022

@DoumanAsh Yes I started using the bundle override approach here.

If the override path is available, it will use it otherwise defaults to the system locations.

It supports two use case scenarios:

  1. local bundle override - update/debug app independent of system version
  2. system default - for baseline OS build, and LTS SDK

For this issue the point is that icuctl.dat should be in /usr/share/flutter instead of /usr/lib.

I'm trying to consolidate the need for this patch:
https://github.com/meta-flutter/meta-flutter/blob/kirkstone/recipes-graphics/flutter-pi/files/0001-path-updates.patch

@ardera
Copy link
Owner

ardera commented Aug 25, 2022

Makes sense, my plan was to make it look inside the app dir first, then inside /usr/share/flutter and then inside /usr/lib.

@ardera
Copy link
Owner

ardera commented Aug 18, 2023

fixed by #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants