Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Git integration does not detect "App name" #34677

Closed
1 task done
rubenmoralesfever opened this issue Jul 3, 2024 · 2 comments
Closed
1 task done

[Bug]: Git integration does not detect "App name" #34677

rubenmoralesfever opened this issue Jul 3, 2024 · 2 comments
Assignees
Labels
Bug Something isn't working Community Reported issues reported by community members Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production

Comments

@rubenmoralesfever
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

I have a protected "master" branch where I found that I misspelt the "App name" in the "App Settings".
The workflow that I would expect to be able to follow is:

  • Create bugfix branch
  • Modify "App name" in the settings
  • Commit
  • Merge branch to master

But I can not do that because the git integration does not detect when I change the "App name" field modification as a change:

image
image

As a workaround I unprotected the master branch, changed the title without any commit, and then protect the branch again.

Steps To Reproduce

  • Change the "App name" in "App Settings"
  • Try to commit

Expected behaviour: detected changes can be committed
Actual behaviour: no changes are detected, and the title is changed automatically in the "Current deployed version" and in the "Preview section"

Public Sample App

No response

Environment

Production

Severity

Low (Cosmetic UI issues)

Issue video log

No response

Version

Cloud - 1.29

@rubenmoralesfever rubenmoralesfever added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Jul 3, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Community Reported issues reported by community members Low An issue that is neither critical nor breaks a user flow Production labels Jul 3, 2024
@nidhi-nair
Copy link
Contributor

Hi @rubenmoralesfever ! We do not in fact persist the application name to the git repository. This is so that you are able to maintain different names for the same app across instances, or even in the same workspace. For example, if you are in a single instance set up, you may wish to demarcate the QA version of the app from the Production version explicitly by calling the names differently. Alternatively, there may be scenarios where you wish to have multiple versions of the same app in the same workspace, which could have led to namespace collision.

However, we do understand that the fact that you are unable to edit a property that is not controlled on git in the protected mode is sub-optimal UX. We'll try to think of a way to allow access to this and other non-git-controlled properties like making an application public, or allowing forking.

I am retaining the priority on this task as low since you already have a workaround, hope the explanation for why application names are not git-controlled makes sense to you?

@Nikhil-Nandagopal
Copy link
Contributor

After some internal deliberation we've concluded that the app name is not meant to be tracked in the repository so that users can explicitly name the staging and production versions of their apps. Since that is a core use case, we won't be picking this issue up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Community Reported issues reported by community members Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production
Projects
None yet
Development

No branches or pull requests

4 participants