Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: take viewport screenshot using safari remote debugger #2413

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

aluedeke
Copy link
Contributor

Starting a discussion @mykola-mokhnach

  • is that a good enough way to take viewport screenshots for web? Do we care that this would (positively) impact customers tests?
  • does appium have a way to take full page screenshots?
  • do we wanna touch the take element screenshot code?
  • TODO: upgrade to latest appium-remote-debugger package once feat: add method to capture viewport appium-remote-debugger#386 is merged

@aluedeke aluedeke marked this pull request as draft June 19, 2024 20:20
@mykola-mokhnach
Copy link
Contributor

The feature has been published in the remote debugger v 11.2.0

@KazuCocoa
Copy link
Member

Let me apply "update branch" to bring newer remote debugger dependency version into this branch

@aluedeke aluedeke marked this pull request as ready for review June 25, 2024 10:06
@mykola-mokhnach mykola-mokhnach merged commit 4402c29 into appium:master Jun 25, 2024
18 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
## [7.19.0](v7.18.0...v7.19.0) (2024-06-25)

### Features

* take viewport screenshot using safari remote debugger ([#2413](#2413)) ([4402c29](4402c29))
Copy link
Contributor

🎉 This PR is included in version 7.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants