-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Avoid unzipping of real device .ipa bundles #2388
Conversation
Will this drops |
Yes it does. I did not see any cases where ios-deploy worked while we were not able to install the app using appium-ios-device lib |
Sounds reasonable. I'll prepare testing app first, which could have kind of large amount of size. |
70mb ipa, which is 200mb+ this pr:
default:
parallel:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so large file, but I have tested improvements in a real device (over USB) in some file format, zipped ipa, ipa, zip, app. The behavior itself seems good for now
So this means we took 6s to push the file? Seems a bit slow for 70MB. If we assume the average USB2 transfer limit is 30MB then it should only take 2-3s |
Could you also please check the application upgrade path on real devices @KazuCocoa ?
|
Yea, tested the same file with the log
|
Yea, I did that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for your help on this PR @KazuCocoa |
## [7.15.0](v7.14.0...v7.15.0) (2024-04-26) ### Features * Avoid unzipping of real device .ipa bundles ([#2388](#2388)) ([520168a](520168a))
🎉 This PR is included in version 7.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
We can install iOS apps on real devices without unzipping them. This should allow to save time on session startup as we don't need to unzip anymore. Also the installation itself should perform better as the size of a compressed .ipa file is lower than the size of an uncompressed one, and we are always limited by the (USB2.0) transfer speed.