fix: terminateApp with devicectl for iOS 17 #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
changed the title
| @@ -192,7 +193,7 @@ class IOSDeploy { | |||
| } | |||
| } | |||
|
|
|||
| async terminateApp(bundleId) { | |||
| async terminateApp(bundleId, platformVersion) { | |||
There was a problem hiding this comment.
I would say it makes sense to keep platformVersion as IOSDeploy property as it might be useful in other methods as well
There was a problem hiding this comment.
Yea, that sounds good. let me do it as a follow-up pr (to pr split)
|
updated ✅ |
mykola-mokhnach
approved these changes
Sep 19, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
## [5.2.1](v5.2.0...v5.2.1) (2023-09-19) ### Bug Fixes * terminateApp with devicectl for iOS 17 ([#1997](#1997)) ([16c7319](16c7319))
|
🎉 This PR is included in version 5.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to appium/appium#18749
This PR kills the process directly against iOS 17 devices via
devicectlcommand without appium-ios-device side modifications.terminateApp via XCTest (WDA) works without any issues, but instrument service gets an issue in iOS 17 with current appium-ios-device implementation. This could have small overhead than existing implementation (because of
devicectl), but should not be a big issue for this usageNote
Maybe we need to build a wrapper module for
devicectlto use it widely for our use. This PR should refer to it later.