refactor!: Deprecate obsolete endpoints #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
reviewed
Sep 2, 2023
| * This is a library command but needs to call 'super' so can't be on | ||
| * a helper object | ||
| */ | ||
| async getSession() { |
There was a problem hiding this comment.
Sounds good, we should still keep the endpoint itself as inspector usage, but no need to return WDA specific, afaik
KazuCocoa
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The includeDeviceCapsToSessionInfo capability has no effect now
BREAKING CHANGE: The obsolete getSession API does not return any extra driver-specific data anymore (e.g. statBarHeight, pixelRatio, viewportRect)
BREAKING CHANGE: Obsolete reset, launchApp and closeApp APIs now throw errors on invocation
BREAKING CHANGE: The minimum node version changed to 16