fix: make whitespace in execute methods insignificant #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
force-pushed
the
boneskull/insignificant-whitespace-in-exec-methods
branch
from
2cc3d59
to
0787517
Compare
jlipps
approved these changes
Apr 20, 2023
boneskull
force-pushed
the
boneskull/insignificant-whitespace-in-exec-methods
branch
from
0787517
to
a311069
Compare
|
@jlipps @mykola-mokhnach I've updated this to allow extra whitespace as well. |
boneskull
force-pushed
the
boneskull/insignificant-whitespace-in-exec-methods
branch
from
a311069
to
9f1a69a
Compare
How this works may change in the future, but XCUITestDriver users expect to be able to use `mobile:foo` instead of or in addition to `mobile: foo`. In addition, users can provide `mobile: foo` with an arbitrary amount of whitespace or ` mobile: foo ` with leading/trailing whitespace. Or a combination thereof. Any change on the Appium side affects more than just this driver, so the change should happen here for now to fix the extant regression. In addition, updated `package-lock.json` since it was out-of-date w/r/t the package version. See appium/appium#18553 Closes appium/appium#18551
boneskull
force-pushed
the
boneskull/insignificant-whitespace-in-exec-methods
branch
from
9f1a69a
to
fca78c0
Compare
mykola-mokhnach
approved these changes
Apr 20, 2023
KazuCocoa
approved these changes
Apr 20, 2023
|
@mykola-mokhnach please merge when satisfied, i don't know how to interpret CI flakes for this repo |
mykola-mokhnach
deleted the
boneskull/insignificant-whitespace-in-exec-methods
branch
github-actions bot
pushed a commit
that referenced
this pull request
Apr 21, 2023
## [4.24.2](v4.24.1...v4.24.2) (2023-04-21) ### Bug Fixes * make whitespace in execute methods insignificant ([#1628](#1628)) ([1dc7777](1dc7777))
|
🎉 This PR is included in version 4.24.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How this works may change in the future, but XCUITestDriver users expect to be able to use
mobile:fooinstead of or in addition tomobile: foo.Any change on the Appium side affects more than just this driver, so the change should happen here for now to fix the extant regression.
In addition, updated
package-lock.jsonsince it was out-of-date w/r/t the package version. See appium/appium#18553Closes appium/appium#18551