chore: remove unused cookies code #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new errors.UnknownError(`Error parsing cookies from result: '${jsCookies}'`); | ||
| } | ||
| }; | ||
|
|
||
| commands.setCookie = async function setCookie (cookie) { |
There was a problem hiding this comment.
it also makes sense to move this helper to cookies.js module
There was a problem hiding this comment.
it would also be interesting to know if the remote debugger has some helpers to set cookies
There was a problem hiding this comment.
Yea, probably can. I found https://github.com/WebKit/WebKit/blob/main/Source/JavaScriptCore/inspector/protocol/Page.json#L191-L196, so am thinking to play something later
mykola-mokhnach
approved these changes
Feb 26, 2023
|
cc @boneskull as cookies stuff's update |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2023
## [4.18.2](v4.18.1...v4.18.2) (2023-02-26) ### Miscellaneous Chores * remove unused cookies code ([#1508](#1508)) ([1f5e2c4](1f5e2c4))
|
🎉 This PR is included in version 4.18.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1484 (comment), I noticed https://github.com/appium/appium-xcuitest-driver/blob/master/lib/commands/cookies.js had
getCookies,deleteCookieand_deleteCookievia remote-debugger's WebInspector code instead of JS script right now.So it probably would be nice to remove the unused methods in
web.js.I checked in a real device, so not in a simulator yet. I'll do a double-check with a simulator later if the current mater uses which code.