CASC-237 Make OpenSAML bootstrap conditional. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
If I don't hear complaints from anyone by tomorrow, I'll merge because technically we have two +1s (since I would assume you would +1 your own implementation :-)) |
|
+1 ;) Sounds like a plan. |
|
+1 |
|
+1 |
battags
added a commit
that referenced
this pull request
Jan 20, 2015
CASC-237 Make OpenSAML bootstrap conditional.
leleuj
pushed a commit
to leleuj/java-cas-client
that referenced
this pull request
Oct 7, 2019
CASC-237 Make OpenSAML bootstrap conditional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branching on
Configuration.getParserPool()seems reasonable since OpenSAML simply won't work without that configured, so it's a reasonable test of prior initialization.