Add support for tomcat 8.5.x #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoayyed
commented
Jul 11, 2017
| <dependency> | ||
| <groupId>org.apache.tomcat.embed</groupId> | ||
| <artifactId>tomcat-embed-core</artifactId> | ||
| <version>8.5.16</version> |
There was a problem hiding this comment.
This bit is different from the Tomcat 8.0.x module
| protected void startInternal() throws LifecycleException { | ||
| super.startInternal(); | ||
| logger.debug("{} starting.", getName()); | ||
| final Realm realm = this.context.getRealm(); |
There was a problem hiding this comment.
In order to allow access to the realm, needed to add a dependency on tomcat-embedded directly.
|
|
||
| /** {@inheritDoc} */ | ||
| @Override | ||
| protected boolean doAuthenticate(final Request request, |
There was a problem hiding this comment.
Had to adjust the method signature as tomcat 8.5.x is different.
leleuj
pushed a commit
to leleuj/java-cas-client
that referenced
this pull request
Oct 7, 2019
Add support for tomcat 8.5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a module
<module>cas-client-integration-tomcat-v85</module>to handle support for tomcat 8.5.xCloses #215