Fix potential deadlock in SchedulingQueue #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be a potential deadlock when:
(1) scheduling thread holds the lock of parent queue and waits for read lock of child queue (calling stack: Scheduler#singleStepSchedule -> Scheduler#findAllocationAsks -> Scheduler#findNextAllocationAskCandidate -> Scheduler#sortSubqueuesFromQueue -> SchedulingQueue#GetPendingResource)
and meanwhile
(2) scheduler event handler holds the lock of child queue and waits for read lock of parent queue (calling stack: Scheduler#handleSchedulerEvent -> Scheduler#processAllocationUpdateEvent -> Scheduler#updateSchedulingRequest -> SchedulingQueue#IncPendingResource)
I think the proper sequence of nested lock should be from parent queue to child queue, the contrary way should be corrected.
Deadlock stacks: