Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1265] fix shellcheck issues in our shell scripts #427

Closed
wants to merge 4 commits into from

Conversation

lowc1012
Copy link
Contributor

@lowc1012 lowc1012 commented Jul 30, 2022

What is this PR for?

Fix issues and add shellcheck into ci

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Fix issues and add shellcheck into CI for other repos

What is the Jira issue?

YUNIKORN-1265

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #427 (d32e3c0) into master (c6faba2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   71.87%   71.87%           
=======================================
  Files          65       65           
  Lines        9602     9602           
=======================================
  Hits         6901     6901           
  Misses       2458     2458           
  Partials      243      243           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilfred-s wilfred-s closed this in d74e728 Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants