Interface update and cleanup (SI pull request #2) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wilfred-s , change looks good. Did all of our UTs still can pass with this patch? |
|
Yes all UT passed in all projects |
|
LGTM， merging now. |
pbacsko
pushed a commit
to pbacsko/incubator-yunikorn-core
that referenced
this pull request
Feb 5, 2024
Instead of hard coding a go version in the Makefile use the version from the go.mod file. The build will fail if the installed tools version is lower than the version from the go.mod file. Removed the lib/go/Makefile check as top level has already checked and the sub Makefile should never be called directly. Fixes: apache#27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding changes for the SI pull request #2 in which we update the interface spec