Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*): Make run-item-sim work on release package. #325

Closed
wants to merge 1 commit into from

Conversation

tbfly
Copy link
Contributor

@tbfly tbfly commented Jun 16, 2017

Purpose of PR:

Fix "run-item-sim.sh" in release package. Make it run properly.

Important ToDos

Please mark each with an "x"

  • A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
  • Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
  • Created unit tests where appropriate
  • Added licenses correct on newly added files
  • Assigned JIRA to self
  • Added documentation in scala docs/java docs, and to website
  • Successfully built and ran all unit tests, verified that all tests pass locally.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"

Does this change break earlier versions?

Is this the beginning of a larger project for which a feature branch should be made?

@andrewpalumbo
Copy link
Member

+1 LGTM

@rawkintrevo
Copy link
Contributor

@andrewpalumbo should we open a JIRA for this and merge it in for 0.13.1?

@tbfly thanks for the contribution! In the future if you could open a jira, assign to yourself, and reference the jira number in the title, that would help.

https://issues.apache.org/jira/projects/MAHOUT/issues

@andrewpalumbo
Copy link
Member

andrewpalumbo commented Jun 29, 2017 via email

@asfgit asfgit closed this in 5a3b4f5 Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants