-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-23015 : Moving from Jackson2 to shaded Gson (Backport HBASE-20587) #616
Conversation
This comment has been minimized.
This comment has been minimized.
hbase-server/src/main/java/org/apache/hadoop/hbase/http/jmx/JMXJsonServlet.java
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java
Show resolved
Hide resolved
Is this a backport of HBASE-20587 or all new? |
Except for supplemental-models.xml and adding hbase-shaded-miscellaneous dependency, mostly this is backport of HBASE-20587 for relevant files(a couple of files on branch-1 don't have Jackson2 and hence, unchanged in this PR) |
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This is looking great! I still need to try using it with a downstream project and after that I think it'll be good to go. When we commit this it needs to go to all branches-1. |
Sure, in the meanwhile let me work on preparing backport patch for branch-1.4 and 1.3 if they have significant changes involved? Update: It seems backport to branch-1.4 doesn't require extra effort, however branch-1.3 does |
ugh. Can't believe I didn't think of jdk requirements. Just built this on branch-1 with
Let me think about what's going to be faster here. We could exclude the stuff other than gson or we could see if updating the dependencies of hbase-thirdparty to be jdk7 compatible. I know guava still works for jdk7 if we use the "android" variant instead of "jre". |
I have some ideas on moving this forward. discussion on HBASE-23052 |
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestOperation.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Okay! a new version of the hbase-thirdparty library is out now and includes a jdk7 compatible relocated GSON. I just published it on the ASF nexus, so it might take a bit for it to show up in maven central. When it does you should be able to update this PR to use the following dependency:
|
That's great! Thanks @busbey |
Building with Need to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the addition of the shaded jar check, I can successfully build with the release profile and verify that the jars we produce are usable downstream (checked by building YCSB with some local changes to allow use of the shaded testing util).
Also the module is visible in Maven Central now:
https://search.maven.org/artifact/org.apache.hbase.thirdparty/hbase-shaded-gson/3.0.0/jar
I plan to merge this tonight and get it back-ported to branch-1.4 as well, unless someone else has more feedback. |
💔 -1 overall
This message was automatically generated. |
This is concerning, but unrelated. I'll chase it down later.
this is HBASE-22732
Not related AFAICT. |
* Backport HBASE-20587 * moving to shaded gson with jdk7 compatibility * Include jackson-mapper-asl for testing-util because of Hadoop * Update shaded jar check to allow hbase-thirdparty libs Signed-off-by: Sean Busbey <[email protected]> Co-authored-by: Duo Zhang <[email protected]>
* Backport HBASE-20587 * moving to shaded gson with jdk7 compatibility * Include jackson-mapper-asl for testing-util because of Hadoop * Update shaded jar check to allow hbase-thirdparty libs Signed-off-by: Sean Busbey <[email protected]> Co-authored-by: Duo Zhang <[email protected]>
No description provided.