Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-22932 Add rs group management methods in Admin and AsyncAdmin #588

Closed
wants to merge 21 commits into from
Closed

HBASE-22932 Add rs group management methods in Admin and AsyncAdmin #588

wants to merge 21 commits into from

Conversation

sunhelly
Copy link
Contributor

@sunhelly sunhelly commented Sep 5, 2019

No description provided.

Apache9 and others added 18 commits August 27, 2019 20:29
@Apache9
HBASE-22664 Move protobuf stuff in hbase-rsgroup to hbase-protocol-sh…
fd75fda 
…aded (#362)

Signed-off-by: Guanghao Zhang <[email protected]>
@Apache9
HBASE-22662 Move RSGroupInfoManager to hbase-server (#368)
c577c94 
Signed-off-by: Guanghao Zhang <[email protected]>
@Apache9
HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re…
fff7d19 
…move hbase-rsgroup module (#399)

Signed-off-by: Zheng Hu <[email protected]>
@Apache9
HBASE-22695 Store the rsgroup of a table in table configuration (#426)
f37fb78 
Signed-off-by: Guanghao Zhang <[email protected]>
@Apache9
HBASE-22809 Allow creating table in group when rs group contains no l…
5762c18 
…ive servers (#464)

Signed-off-by: Guanghao Zhang <[email protected]>
@sunhelly @Apache9
HBASE-22820 Do not need to persist default rs group now (#482)
8253658 
Signed-off-by: Duo Zhang <[email protected]>
@Apache9
HBASE-22819 Automatically migrate the rs group config for table after H…
548e8c4 
…BASE-22695 (#498)

Signed-off-by: Guanghao Zhang <[email protected]>
@Apache9
HBASE-22664 Move protobuf stuff in hbase-rsgroup to hbase-protocol-sh…
2dd749a 
…aded (#362)

Signed-off-by: Guanghao Zhang <[email protected]>
@Apache9
HBASE-22662 Move RSGroupInfoManager to hbase-server (#368)
4dae147 
Signed-off-by: Guanghao Zhang <[email protected]>
@Apache9
HBASE-22676 Move all the code in hbase-rsgroup to hbase-server and re…
320fcdf 
…move hbase-rsgroup module (#399)

Signed-off-by: Zheng Hu <[email protected]>
@Apache9
HBASE-22695 Store the rsgroup of a table in table configuration (#426)
71d9f4c 
Signed-off-by: Guanghao Zhang <[email protected]>
@Apache9
HBASE-22809 Allow creating table in group when rs group contains no l…
dfa95fc 
…ive servers (#464)

Signed-off-by: Guanghao Zhang <[email protected]>
@sunhelly @Apache9
HBASE-22820 Do not need to persist default rs group now (#482)
da6f51d 
Signed-off-by: Duo Zhang <[email protected]>
@Apache9
HBASE-22819 Automatically migrate the rs group config for table after H…
ba13759 
…BASE-22695 (#498)

Signed-off-by: Guanghao Zhang <[email protected]>
@Apache9
HBASE-22729 Start RSGroupInfoManager as default (#555)
855c092 
Amending-Author: Duo Zhang <[email protected]>
Signed-off-by: stack <[email protected]>
@sunhelly
HBASE-22932 Add rs group management methods in Admin and AsyncAdmin
40e5060
@sunhelly
Merge branch 'HBASE-22514' of https://github.com/apache/hbase into HB…
c3dfc67 
…ASE-22514
@sunhelly
Changed the structure.
61cb649
@sunhelly
Copy link
Contributor Author

sunhelly commented Sep 5, 2019

Not completed.
Hasn't change UTs, and plan to add

rpc GetRSGroupInfoOfTable(GetRSGroupInfoOfTableRequest)
returns (GetRSGroupInfoOfTableResponse);

and a method setRSGroup(TableName tableName).

Pushed here for some suggestions.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 1m 5s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💙 prototool 0m 1s prototool was not available.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ HBASE-22514 Compile Tests _
💙 mvndep 0m 33s Maven dependency ordering for branch
💚 mvninstall 5m 46s HBASE-22514 passed
💚 compile 2m 36s HBASE-22514 passed
💚 checkstyle 2m 51s HBASE-22514 passed
💚 shadedjars 4m 56s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 1m 49s HBASE-22514 passed
💙 spotbugs 1m 47s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 11m 36s HBASE-22514 passed
_ Patch Compile Tests _
💙 mvndep 0m 14s Maven dependency ordering for patch
💔 mvninstall 3m 39s root in the patch failed.
💔 compile 1m 1s hbase-server in the patch failed.
💔 cc 1m 1s hbase-server in the patch failed.
💔 javac 1m 1s hbase-server in the patch failed.
💔 checkstyle 0m 40s hbase-client: The patch generated 18 new + 162 unchanged - 0 fixed = 180 total (was 162)
💔 checkstyle 1m 34s hbase-server: The patch generated 26 new + 159 unchanged - 0 fixed = 185 total (was 159)
💚 whitespace 0m 0s The patch has no whitespace issues.
💔 shadedjars 4m 19s patch has 98 errors when building our shaded downstream artifacts.
💔 hadoopcheck 2m 18s The patch causes 98 errors with Hadoop v2.8.5.
💔 hadoopcheck 4m 31s The patch causes 98 errors with Hadoop v2.9.2.
💔 hadoopcheck 6m 46s The patch causes 98 errors with Hadoop v3.1.2.
💔 hbaseprotoc 0m 45s hbase-server in the patch failed.
💔 javadoc 0m 38s hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
💔 findbugs 0m 56s hbase-server in the patch failed.
_ Other Tests _
💚 unit 0m 41s hbase-protocol-shaded in the patch passed.
💚 unit 1m 44s hbase-client in the patch passed.
💔 unit 0m 54s hbase-server in the patch failed.
💚 unit 3m 41s hbase-thrift in the patch passed.
💚 asflicense 0m 37s The patch does not generate ASF License warnings.
73m 11s
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/Dockerfile
GITHUB PR #588
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux a13a2f70f93a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-588/out/precommit/personality/provided.sh
git revision HBASE-22514 / 855c092
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/patch-compile-hbase-server.txt
cc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/patch-compile-hbase-server.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/diff-checkstyle-hbase-client.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/patch-javac-3.1.2.txt
hbaseprotoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/patch-hbaseprotoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/diff-javadoc-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/testReport/
Max. process+thread count 1751 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-588/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@asfgit asfgit force-pushed the HBASE-22514 branch 3 times, most recently from 1686157 to 4ca760f Compare September 10, 2019 03:16
@sunhelly sunhelly closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunhelly @Apache-HBase @Apache9