-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25986 set default value of normalization enabled from hbase site #3372
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@virajjasani Mind having a look in your free cycles. |
I think rather than site config, having a switch command would be more beneficial. |
We already have a switch command which switch the cluster level normalizer. This change is to set default table descriptor value that to something a user wants. The idea here is to enable normalizer by default to true/false for a table using configuration similar to what we do for cluster level normalizer configuration. We can always switch the normalizer to false at cluster level if there is an issue. |
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the intended behavior? Can you outline how the system should behave based on presence/absence of values in hbase-site, TableDescriptor, and the ZooKeeper flag using a truth table?
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java
Outdated
Show resolved
Hide resolved
3b7ff5b
to
28769a9
Compare
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
28769a9
to
3f602b2
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@ndimiduk - The above table defines the order in which value is being considered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment, still trying to understand compatibility concerns.
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java
Outdated
Show resolved
Hide resolved
3f602b2
to
21b8b46
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Test failure seems to be unrelated. @virajjasani FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments, almost there.
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizer.java
Outdated
Show resolved
Hide resolved
...e-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerWorker.java
Outdated
Show resolved
Hide resolved
...e-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerWorker.java
Outdated
Show resolved
Hide resolved
...e-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerWorker.java
Outdated
Show resolved
Hide resolved
21b8b46
to
548fedd
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, please create branch-2 and branch-1 PRs. We can merge them together once QA results are published.
🎊 +1 overall
This message was automatically generated. |
#3476) (#3372) Signed-off-by: Viraj Jasani <[email protected]>
#3476) (#3372) Signed-off-by: Viraj Jasani <[email protected]>
#3492) (#3372) Signed-off-by: Viraj Jasani <[email protected]>
No description provided.