-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1 #251
Conversation
Just opening a PR for this backport. I think we are blocked on issues with precommit handling of the JDK version specific conditional build stuff that could permanently break precommit, but not any issue with this patch itself. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I can make time this holiday weekend to work out the qabot things.
will do a more thorough review as a part of that as well.
c928fc6
to
ffc4f3e
Compare
This comment has been minimized.
This comment has been minimized.
ffc4f3e
to
a8a5b16
Compare
This comment has been minimized.
This comment has been minimized.
a8a5b16
to
f4a176d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f4a176d
to
29613fc
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat, pushing my updates worked.
the changes to hbase-personality will need to go to all branches. this should fix most of the complaints from qa bot. it won't fix the xml thing (it's a long standing issue on jdk7 branches), and I haven't dug into what's up with the unit tests that failed.
dev-support/hbase-personality.sh
Outdated
# on branches-1, the hbase-tinylfu-blockcache only works for jdk8. so if it changes | ||
# run whatever test is requested at the top level so that maven can handle only including | ||
# the module when the correct jdk is around. | ||
if [[ "${MODULES[*]}" =~ hbase-tinylfu-blockcache ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shellcheck:25: warning: Did you forget to close this double quoted string? [SC1078]
This comment has been minimized.
This comment has been minimized.
e27842f
to
a57a936
Compare
This comment has been minimized.
This comment has been minimized.
a57a936
to
fb4513b
Compare
This comment has been minimized.
This comment has been minimized.
fb4513b
to
9abf0b8
Compare
This comment has been minimized.
This comment has been minimized.
9abf0b8
to
b7d6af8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Let's finish this? @apurtell |
Was this waiting on me and handling the jdk7/jdk8 bit? If so, sorry been swamped. I can block out some time this week to give it another go. |
@apurtell close? |
785829d
to
e5c0921
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we close out this PR since it has been hanging out a while @apurtell ? Thanks.
Oh, had a push 13 days ago so not so old.... |
This comment has been minimized.
This comment has been minimized.
I would really like to not close this out. Iirc it's just waiting on an update to our CI tooling to properly handle jdk dependent modules. That's debt that has a hard time finding help, to be sure. |
e5c0921
to
a263f0b
Compare
This comment has been minimized.
This comment has been minimized.
a263f0b
to
4daa600
Compare
This comment has been minimized.
This comment has been minimized.
4daa600
to
06b3055
Compare
This comment has been minimized.
This comment has been minimized.
06b3055
to
b70c26b
Compare
This comment has been minimized.
This comment has been minimized.
b70c26b
to
2028e56
Compare
This comment has been minimized.
This comment has been minimized.
2028e56
to
aa17212
Compare
This comment has been minimized.
This comment has been minimized.
aa17212
to
4be8fd0
Compare
This comment has been minimized.
This comment has been minimized.
4be8fd0
to
c1a597b
Compare
💔 -1 overall
This message was automatically generated. |
FYI stack I'll be taking a look at getting this PR merged over the weekend. |
HBASE-15560 W-TinyLFU based BlockCache (Ben Manes)
c1a597b
to
0a0ff9f
Compare
💔 -1 overall
This message was automatically generated. |
Any progress here? |
HBASE-15560 W-TinyLFU based BlockCache (Ben Manes)