-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-19577 Use log4j2 instead of log4j for logging #1708
Conversation
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
For log4j2, there is no way to configuration a category with the grammer like log4j.rootLogger=INFO,console Instead, you have to config the log level and log appender separately. So I changed the start up script a bit to have HBASE_ROOT_LOGGER_LEVEL and HBASE_ROOT_LOGGER_APPENDER to specify these two configs separately. This is an incompatible change I think. And I could not find an easy way to purge the dependencies on log4j from hadoop, as hadoop is deeply combined with log4j in the metrics system, where the org.apache.hadoop.log.metrics.EventCounter is a sub class of the log4j AppenderSkeleton. Just introducing log4j dependency is fine, as we can make sure slf4j-log4j12 is not in our classpath then no log will be redirect to log4j.But I think these metrics will be broken as we will not output logs to these EventCounters. Maybe we should introduce our own jvm metrics which depends on log4j2? |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
2b5c781
to
afaf0db
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Several UTs in hbase-mapreduce module are still failing because of the launched container wants to load log4j.properties and set FileAppender. Let me dig more. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
OK, good, all green. Let me merge. |
No description provided.