HBASE-23993 Use loopback for zk standalone server in minizkcluster #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
HorizonNet
reviewed
Mar 15, 2020
| @@ -575,7 +575,7 @@ def assert_tablecfs_equal(table_cfs, table_cfs_map) | |||
| end | |||
|
|
|||
| define_test "set_peer_bandwidth: works with peer bandwidth upper limit" do | |||
| cluster_key = "localhost:2181:/hbase-test" | |||
| cluster_key = MiniZookeeperCluster::HOST + ":2181:/hbase-test" | |||
There was a problem hiding this comment.
Test failure looks related to this one. Does the MiniZookeeperCluster need initialization before?
There was a problem hiding this comment.
Thank you for taking a look @HorizonNet ... Let me see.
There was a problem hiding this comment.
s/MiniZookeeperCluster::HOST/MiniZooKeeperCluster::HOST/
... the 'k' capitialization. Joy!
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Is the build still running or is it just dead? |
|
@HorizonNet Looks sick. I see this: Waiting to resume part of HBase-PreCommit-GitHub-PR » PR-1291 #2: Waiting to resume part of HBase-PreCommit-GitHub-PR » PR-1291 #2: Waiting to resume part of HBase-PreCommit-GitHub-PR » PR-1291 #2: Waiting to resume part of HBase-PreCommit-GitHub-PR » PR-1291 #2: Waiting for next available executor on ‘H5’ Let me retry. I killed it and restarted the build. Will probably get same thing. Will keep an eye on it. On the failed TestAsyncTableGetMultiThreaded, there seems to be a general issue around cluster shutdown in teardown. I'll work on that next. Unrelated to this patch it seems (just tried locally with and w/o the patch) |
|
Now I see this... .... Will wait a while. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
IIRC, some secure related tests will fail on some platform if we use 127.0.0.1 instead of localhost... |
|
@Apache9 You know which? I want to push this because it 'fixes' a general issue where standalone zk cluster won't come up because client and server can't find each other. |
|
Never mind, only a small part of the UTs are secure and it only fails on a specific platform. If someone hit it let's try to fix it then. |
|
The hbase-shell failure related? |
|
🎊 +1 overall
This message was automatically generated. |
|
Did a new push w/ checkstyle fix. Checked shell test locally and seems fine. Lets see. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java Have client and server use loopback instead of 'localhost'
|
The shell failures were legit. For the other tests that are failing, OOME. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Shell tests pass now. The remaining timeout seems unrelated and I'm working on these tests that don't complete in a follow-up. Merging. |
asfgit
pushed a commit
that referenced
this pull request
Mar 18, 2020
…1291) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java Have client and server use loopback instead of 'localhost' Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Jan Hentschel <[email protected]>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
…pache#1291) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java Have client and server use loopback instead of 'localhost' Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Jan Hentschel <[email protected]>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
…pache#1291) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java Have client and server use loopback instead of 'localhost' Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Jan Hentschel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
Have client and server use loopback instead of 'localhost'