Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Some test cases still rely on the REST protocol #14340

Open
3 of 4 tasks
walklown opened this issue Jun 18, 2024 · 3 comments
Open
3 of 4 tasks

[Bug] Some test cases still rely on the REST protocol #14340

walklown opened this issue Jun 18, 2024 · 3 comments
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@walklown
Copy link
Contributor

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

Dubbo 3.3

Steps to reproduce this issue

Rest Protocol has been move to dubbo-spi-extension, But some test cases still rely on the REST protocol.
image

What you expected to happen

Hope to pass the test case.
Which was better?

  1. Add org.apache.dubbo.extensions:dubbo-rpc-rest dependency to the test case
  2. Replace the rest protocol in the test case with triple

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@walklown walklown added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels Jun 18, 2024
@AlbumenJ
Copy link
Member

@songxiaosheng We need to release spi-extension for 3.3.x ASAP.

@wcy666103
Copy link
Contributor

I think it's better to replace it with tri, extensions have their own samples repository, try not to mix it up?

@wcy666103
Copy link
Contributor

I think it's better to replace it with tri, extensions have their own samples repository, try not to mix it up?

I will submit this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Status: Todo
Development

No branches or pull requests

3 participants