Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod: update the comments in protocol directory #602

Merged
merged 5 commits into from
Jun 14, 2020

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Jun 11, 2020

What this PR does:

  • update the comments in protocol directory

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@zouyx zouyx marked this pull request as draft June 11, 2020 16:10
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #602 into develop will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #602      +/-   ##
===========================================
- Coverage    67.20%   67.14%   -0.07%     
===========================================
  Files          190      190              
  Lines         9918     9918              
===========================================
- Hits          6665     6659       -6     
- Misses        2596     2603       +7     
+ Partials       657      656       -1     
Impacted Files Coverage Δ
protocol/dubbo/client.go 67.87% <ø> (ø)
protocol/dubbo/codec.go 72.50% <ø> (-5.00%) ⬇️
protocol/dubbo/config.go 13.15% <ø> (ø)
protocol/dubbo/dubbo_protocol.go 91.83% <ø> (ø)
protocol/dubbo/listener.go 57.52% <0.00%> (ø)
protocol/grpc/client.go 61.70% <ø> (ø)
protocol/grpc/grpc_exporter.go 100.00% <ø> (ø)
protocol/grpc/grpc_invoker.go 70.96% <0.00%> (ø)
protocol/grpc/grpc_protocol.go 95.23% <ø> (ø)
protocol/grpc/server.go 68.42% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f71f7...57f75ee. Read the comment docs.

@zouyx zouyx marked this pull request as ready for review June 13, 2020 12:46
@zouyx zouyx linked an issue Jun 13, 2020 that may be closed by this pull request
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	protocol/grpc/client.go
@fangyincheng fangyincheng merged commit 93a655f into apache:develop Jun 14, 2020
@zouyx zouyx deleted the feature/addProtocolComment branch June 24, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhance] Add comments for protocol directory
5 participants