Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should return error when NewURL failed. #266

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

imxyb
Copy link
Contributor

@imxyb imxyb commented Nov 26, 2019

Signed-off-by: imxyb [email protected]

What this PR does:
should return error when NewURL failed.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #266 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage      65%   65.06%   +0.05%     
==========================================
  Files         105      105              
  Lines        6792     6792              
==========================================
+ Hits         4415     4419       +4     
+ Misses       1932     1928       -4     
  Partials      445      445
Impacted Files Coverage Δ
config_center/parser/configuration_parser.go 2.14% <0%> (ø) ⬆️
remoting/zookeeper/client.go 64.45% <0%> (+0.57%) ⬆️
remoting/zookeeper/listener.go 47.93% <0%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77b772...e4561b6. Read the comment docs.

@hxmhlt hxmhlt merged commit 78e7ed0 into apache:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants