Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 update nacos version v1 #2142

Merged
merged 1 commit into from
Nov 28, 2022
Merged

3.0 update nacos version v1 #2142

merged 1 commit into from
Nov 28, 2022

Conversation

binbin0325
Copy link
Member

What this PR does:
降低nacos 到v1.x版本,等到支持批量注册时在升级nacos sdk v2.x。
Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@sonarcloud
Copy link

sonarcloud bot commented Nov 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #2142 (1e92996) into 3.0 (9007a29) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              3.0    #2142      +/-   ##
==========================================
- Coverage   44.34%   44.30%   -0.04%     
==========================================
  Files         283      283              
  Lines       17016    17028      +12     
==========================================
  Hits         7545     7545              
- Misses       8678     8690      +12     
  Partials      793      793              
Impacted Files Coverage Δ
config_center/nacos/impl.go 40.59% <ø> (ø)
config_center/nacos/listener.go 0.00% <ø> (ø)
metadata/report/nacos/report.go 43.57% <ø> (ø)
registry/nacos/listener.go 0.00% <0.00%> (ø)
registry/nacos/registry.go 46.00% <ø> (ø)
registry/nacos/service_discovery.go 42.24% <0.00%> (ø)
remoting/nacos/builder.go 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlexStocks AlexStocks merged commit 23cb11a into apache:3.0 Nov 28, 2022
@justxuewei justxuewei added this to the v3.0.4 milestone Dec 4, 2022
binbin0325 added a commit to binbin0325/dubbo-go that referenced this pull request Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants