Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: decode net stream bytes as getty rule #1820

Merged
merged 4 commits into from
Apr 15, 2022
Merged

Fix: decode net stream bytes as getty rule #1820

merged 4 commits into from
Apr 15, 2022

Conversation

AlexStocks
Copy link
Contributor

What this PR does:

the current dubbo-go do not follow the getty rule when decoding tcp network streams

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2022

Codecov Report

Merging #1820 (0f77532) into 3.0 (7bc593b) will decrease coverage by 0.10%.
The diff coverage is 11.62%.

@@            Coverage Diff             @@
##              3.0    #1820      +/-   ##
==========================================
- Coverage   46.85%   46.75%   -0.11%     
==========================================
  Files         298      298              
  Lines       17163    17178      +15     
==========================================
- Hits         8042     8031      -11     
- Misses       8275     8293      +18     
- Partials      846      854       +8     
Impacted Files Coverage Δ
protocol/dubbo/dubbo_codec.go 1.75% <0.00%> (-0.13%) ⬇️
protocol/dubbo/impl/codec.go 41.66% <0.00%> (-0.55%) ⬇️
remoting/getty/readwriter.go 39.28% <27.27%> (-3.31%) ⬇️
remoting/getty/listener.go 26.92% <50.00%> (ø)
filter/metrics/filter.go 85.00% <0.00%> (-15.00%) ⬇️
...tocol/rest/server/server_impl/go_restful_server.go 41.37% <0.00%> (-3.45%) ⬇️
registry/nacos/listener.go 78.26% <0.00%> (-2.61%) ⬇️
remoting/xds/client.go 56.00% <0.00%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc593b...0f77532. Read the comment docs.

Copy link
Contributor

@ztelur ztelur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix ci failure

@AlexStocks
Copy link
Contributor Author

pls do not merge this pr

@AlexStocks AlexStocks force-pushed the fix/getty-eof branch 3 times, most recently from 6f29aed to 18a6f94 Compare April 12, 2022 10:55
@AlexStocks AlexStocks changed the title Fix: decode net stream bytes as getty standard Fix: decode net stream bytes as getty rule Apr 12, 2022
@cvictory cvictory self-requested a review April 15, 2022 05:10
@cvictory
Copy link
Contributor

LGTM

@AlexStocks AlexStocks merged commit 605764e into 3.0 Apr 15, 2022
@AlexStocks AlexStocks deleted the fix/getty-eof branch April 20, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants