Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gost): upgrade gost dependency version and remove redundant code #1771

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

Mulavar
Copy link
Member

@Mulavar Mulavar commented Mar 1, 2022

What this PR does:

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

Codecov Report

Merging #1771 (84c7cf2) into 3.0 (ef94f01) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 84c7cf2 differs from pull request most recent head c9ed4e0. Consider uploading reports for the commit c9ed4e0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1771      +/-   ##
==========================================
- Coverage   47.38%   47.33%   -0.06%     
==========================================
  Files         259      259              
  Lines       14955    14947       -8     
==========================================
- Hits         7087     7075      -12     
- Misses       7091     7097       +6     
+ Partials      777      775       -2     
Impacted Files Coverage Δ
remoting/zookeeper/listener.go 0.00% <0.00%> (ø)
cluster/cluster/base/cluster_invoker.go 24.44% <0.00%> (-13.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef94f01...c9ed4e0. Read the comment docs.

@justxuewei justxuewei merged commit 2154cd0 into apache:3.0 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants