Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zap log addCaller #1732

Merged
merged 1 commit into from
Jan 26, 2022
Merged

zap log addCaller #1732

merged 1 commit into from
Jan 26, 2022

Conversation

binbin0325
Copy link
Member

What this PR does:
config.ZapConfig.Build(zap.AddCallerSkip(1)) This is not correct, the log does not print the caller

add zap.AddCaller() turn on the print caller switch.
Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

Codecov Report

Merging #1732 (a4a9238) into 3.0 (13368cf) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head a4a9238 differs from pull request most recent head 39068c1. Consider uploading reports for the commit 39068c1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1732      +/-   ##
==========================================
- Coverage   42.84%   42.71%   -0.13%     
==========================================
  Files         256      256              
  Lines       14774    14774              
==========================================
- Hits         6330     6311      -19     
- Misses       7722     7742      +20     
+ Partials      722      721       -1     
Impacted Files Coverage Δ
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-8.61%) ⬇️
registry/nacos/listener.go 77.96% <0.00%> (-2.55%) ⬇️
metrics/prometheus/reporter.go 26.85% <0.00%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13368cf...39068c1. Read the comment docs.

@AlexStocks AlexStocks merged commit bf7c407 into apache:3.0 Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants