Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rft: Restructuring remoting metadata service #1227

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Rft: Restructuring remoting metadata service #1227

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80171e9
restructure remoting metadata serivce
justxuewei May 30, 2021
f37afe1
conform to the code style of imports
justxuewei May 30, 2021
8a6baae
Merge branch 'refs/heads/xavierniu/3.0' into xavierniu/restructure-re…
justxuewei May 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
conform to the code style of imports
  • Loading branch information
@justxuewei
justxuewei committed May 30, 2021
commit f37afe11132ab8338362002f61fbd161b7e63246
5 changes: 4 additions & 1 deletion common/extension/metadata_remote.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,17 @@
package extension

import (
"dubbo.apache.org/dubbo-go/v3/metadata/service"
"fmt"
)

import (
perrors "github.com/pkg/errors"
)

import (
"dubbo.apache.org/dubbo-go/v3/metadata/service"
)

type remotingMetadataServiceCreator func() (service.RemotingMetadataService, error)

var (
Expand Down
10 changes: 8 additions & 2 deletions metadata/service/remoting/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@

package remoting

import (
"sync"
)

import (
"go.uber.org/atomic"
)

import (
"dubbo.apache.org/dubbo-go/v3/common"
"dubbo.apache.org/dubbo-go/v3/common/constant"
Expand All @@ -28,8 +36,6 @@ import (
"dubbo.apache.org/dubbo-go/v3/metadata/service"
"dubbo.apache.org/dubbo-go/v3/metadata/service/inmemory"
"dubbo.apache.org/dubbo-go/v3/registry"
"go.uber.org/atomic"
"sync"
)

type MetadataService struct {
Expand Down