Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should lint success #18

Merged
merged 1 commit into from
Nov 11, 2016
Merged

fix: should lint success #18

merged 1 commit into from
Nov 11, 2016

Conversation

benjycui
Copy link
Contributor

@benjycui benjycui commented Nov 9, 2016

@@ -163,7 +163,7 @@ gulp.task('compile', () => {
const assets = gulp.src(['components/**/*.@(png|svg)']).pipe(gulp.dest('lib'));
let error = 0;
const tsResult = gulp.src([
'components/**/*.tsx',
'components/**!demo/*.tsx',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo 下面的 tsx 无需编译。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里好像有问题,现在是所有 tsx 都不编译了。

@@ -64,7 +64,7 @@
"no-unused-new": true,
"no-unused-variable": [
true,
"react"
{ "ignore-pattern": "^React$" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

antd 和 antd-mobile 都没有用到类似 react/addon 的东西。

@benjycui
Copy link
Contributor Author

ping~

@benjycui benjycui assigned afc163 and unassigned yiminghe Nov 11, 2016
@afc163 afc163 merged commit f049b57 into master Nov 11, 2016
@afc163 afc163 deleted the fix-lint branch November 11, 2016 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants