This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(spec): do not count requestAnimationFrame as a pending timer #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikerman
force-pushed
the
master
branch
2 times, most recently
from
df6610e
to
7fc7291
Compare
| @@ -35,7 +36,7 @@ | |||
|
|
|||
| scheduleFunction( | |||
| cb: Function, delay: number, args: any[] = [], isPeriodic: boolean = false, | |||
| id: number = -1): number { | |||
| isRequestAnimationFrame: boolean = false, id: number = -1): number { | |||
There was a problem hiding this comment.
@vikerman , should we also add an option flag in FakeAsyncTestSpec to control whether to consider RAF as timer or not?
constructor(namePrefix: string, isRequestAnimationFrame: boolean = false) {
this.name = 'fakeAsyncTestZone for ' + namePrefix;
this.isRequestAnimationFrame = isRequestAnimationFrame;
}There was a problem hiding this comment.
Done. Added it as an optional parameter to FakeAsyncTestSpec. Will enforce it in Angular 5.0 as a breaking change but leave it as it is for now.
We added a new fature to FakeAsyncTestSpec to treat a requestAnimationFrame as a timer with 16ms. However this breaks existing Angular project tests because the RAF is reported as a pending timer at the end of the test. This change makes sure that existing Angular tests are not broken by not counting RAF-s as pending timers at the end of a test.
mhevery
approved these changes
Jul 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a new fature to FakeAsyncTestSpec to treat a
requestAnimationFrame as a timer with 16ms. However this breaks existing
Angular project tests because the RAF is reported as a pending timer at
the end of the test.
This change makes sure that existing Angular tests are not broken by not
counting RAF-s as pending timers at the end of a test.