This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(error): remove throw in Error constructor to improve performance in IE11 #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaLiPassion
force-pushed
the
perf
branch
2 times, most recently
from
d99f8ea
to
7a5e2a2
Compare
…rror.stackTraceLimit = 0, add null check
|
@mhevery Could we have a review of this soon? Pretty big performance issue |
mhevery
approved these changes
Apr 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #691.
in pervious modification, error.stack will be constructed in Error constructor, this will impact the performance of IE very badly, so in this PR, the auto-throw is removed.
fix #698.
when Error.stackTraceLimit is set to 0, the stack will be undefined, so we don't need to generate longstacktrace when stackTraceLimit = 0, it will improve performance in some test environment (such as some karma-test-shim for IE)