Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix #569, request will cause updateTaskCount failed if we call abort … #570

Merged
merged 1 commit into from
Jan 12, 2017

Conversation

JiaLiPassion
Copy link
Collaborator

Fix the issue #287, #569.

@vicb
Copy link
Contributor

vicb commented Dec 29, 2016

Could you describe the error case in the commit message / inline comment and squash the commits ?
Thanks

@JiaLiPassion
Copy link
Collaborator Author

JiaLiPassion commented Dec 30, 2016

@vicb, thank you for the review, I have added inline comment and squash the commits, please review.

… abort multipletimes

the fix is check whether the xhr has been aborted before abort the request
@RicardoVaranda
Copy link

@vicb can this be merged? Really need this fix so I can get rid of those annoying console messages.

@mhevery mhevery merged commit 62f1449 into angular:master Jan 12, 2017
@JiaLiPassion JiaLiPassion deleted the issue-287 branch January 12, 2017 01:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants