Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix(browser): patchTimer cancelAnimationFrame #353

Merged
merged 1 commit into from
Jun 6, 2016

Conversation

tom5760
Copy link
Contributor

@tom5760 tom5760 commented May 25, 2016

Call cancelAnimationFrame instead of cancelMicroTaskAnimationFrame.

Fixes #326 and Leaflet/Leaflet#4588

Call cancelAnimationFrame instead of cancelMicroTaskAnimationFrame.

Fixes angular#326 and Leaflet/Leaflet#4588
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@tom5760
Copy link
Contributor Author

tom5760 commented May 25, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@kaynz
Copy link

kaynz commented Jun 6, 2016

Waiting for a merge 👍

@Mlaval

@marclaval
Copy link
Contributor

@mhevery please have a look

@mhevery mhevery merged commit bf77fbb into angular:master Jun 6, 2016
@tom5760 tom5760 deleted the cancel-animation-frame branch June 6, 2016 20:30
@kaynz
Copy link

kaynz commented Jul 26, 2016

@mhevry Will there be a release soon with this bugfix? This bug affects every leaflet user and is really breaking the map =/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants