This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
feat(zonespec): add a spec for synchronous tests #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will throw an exception if any asynchornous microtask or macrotask is scheduled. Allows event tasks to be scheduled.
|
LGTM. I spent a while thinking about whether we want to fail if a microtask is scheduled, or if that's too restrictive. But I think I like this commit the way it is, because you're ensuring that everything written in the test really has already run by the time we get to the end of the function. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will throw an exception if any asynchornous microtask or macrotask is scheduled. Allows event tasks to be scheduled.