Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failures don't return error codes #54

Closed
rgetz opened this issue Jul 28, 2016 · 2 comments
Closed

test failures don't return error codes #54

rgetz opened this issue Jul 28, 2016 · 2 comments
Assignees
Labels

Comments

@rgetz
Copy link
Contributor

rgetz commented Jul 28, 2016

It use to be when a profile/test was run, and the test failed, the OSC application returned a non-success error code, so that shell scripts would understand what was going on.

This is no longer the case, and causes issues in the test infrastructure.

I don't know who wants to have a look at things (or who has time?)

Thanks
-Robin

@radhermit
Copy link
Contributor

I've had a patch sitting around for doing vibration tests fully on the command line running osc under Xvfb that probably handles this fix among other things (https://github.com/analogdevicesinc/board-tests/blob/master/picozed-sdr1-brk/vibration/osc-cli-test.patch).

In particular, the return codes from the profile loading part of the patch should fix this. I'll clean it up and push the relevant changes.

@rgetz
Copy link
Contributor Author

rgetz commented Jul 29, 2016

Yeah - that looks like it should fix things up. What's your schedule? (I know you have more important things to work on right now).

Thanks
-Robin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants