-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gulp from 4.0.2 to 5.0.0 #5038
Conversation
Bumps [gulp](https://github.com/gulpjs/gulp) from 4.0.2 to 5.0.0. - [Release notes](https://github.com/gulpjs/gulp/releases) - [Changelog](https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md) - [Commits](gulpjs/gulp@v4.0.2...v5.0.0) --- updated-dependencies: - dependency-name: gulp dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for a15f6a5 |
It looks like we need to set the encoding on some of the binary streams – in particular the font is being corrupted when copied, which is why we're seeing visual regressions in Percy. I'll take a look and see if I can get it working correctly. |
Gulp v5 changes the way that streams are encoded [1]: > Our streams now default to UTF-8 encoding. Previously, our streams took whatever data was emitted without considering any encoding. However, in this release, we resolved a 10 year old issue to support custom encodings and we default these to UTF-8. Most usage of gulp won’t need to change anything, but certain plugins may produce non-UTF-8 output and you’ll need to set `{ encoding: false }` on your gulp streams. As the fonts and images are binary we need to set `encoding: false` to avoid them being corrupted. [1]: https://medium.com/gulpjs/announcing-gulp-v5-c67d077dbdb7#8f65
I've pushed a commit to fix the broken font and images. From a quick look at the v5 blog post I can't see anything obvious that affects us (and the tests are passing…) but this could definitely do with at least one more pair of eyes before merging! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Percy's happy. The tests are happy. I'm happy.
I agree with Ollie that it doesn't look like the other breaking changes impact us. Ollie's change is nice and simple.
The one thing that sticks out to me that is by no means a blocker for merging is the line in features:
Added support for
gulpile.cjs
andgulpfile.mjs
...which suggests they weren't already supported, however we have our gulpfile
as an mjs
file. I haven't bothered to dig into this before writing this comment but are we doing something special to allow for this that we can now scoop out? Or have I misunderstood the release notes?
From digging through t'GitHubs it seems that Gulp has supported The recent change appears to have expanded what the We're currently doing this: import gulp from 'gulp'
gulp.task(…)
gulp.src(…)
gulp.dest(…)
gulp.watch(…) Whereas as of Gulp 5 we can do this: import { task, src, dest, watch } from 'gulp'
task(…)
src(…)
dest(…)
watch(…) Minor change, but it's an option. Weirdly, it seems like the CJS version of Gulp has supported the equivalent of this for some time, so it's only new to ESM. (Also: It seems that using |
….0.0 Bump gulp from 4.0.2 to 5.0.0
Bumps gulp from 4.0.2 to 5.0.0.
Release notes
Sourced from gulp's releases.
... (truncated)
Changelog
Sourced from gulp's changelog.
... (truncated)
Commits
5c4c547
chore: Release 5.0.0 (#2762)bf72116
chore: Add index.mjs to files listb00de68
feat: Provide an ESM export (#2760)72668c6
chore!: Normalize repository, dropping node <10.13 support (#2758)85896d4
chore(docs): Update stream handbook link (#2711)818bd73
Docs: Remove gulp-sourcemaps because it is built-in (#2592)598f971
Docs: Fix broken link in recipe (#2571)9877de0
Docs: Guide CustomRegistries to maintain properties on tasks (fixes #2561) (#...f91c388
Docs: Remove typo in custom registry docs (#2543)df25250
Docs: Fix typo in task docs (#2524)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)