Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): correly parse usage hosts #3622

Merged
merged 15 commits into from
Aug 30, 2024
Merged

fix(clients): correly parse usage hosts #3622

merged 15 commits into from
Aug 30, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Aug 30, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2857

Changes included:

closes #3621

correctly parses the servers when it's not an appID or regional host

@shortcuts shortcuts self-assigned this Aug 30, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 30, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 31890251e99c122f0f794e2adf2f297dd5e2907e
🍃 Generated commit 74728432bdbb8cb76f197473bd246c26f3cdacdf
🌲 Generated branch generated/fix/usage
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1650
php 1472
csharp 1037
python 952
java 944
ruby 931
swift 768
go 571
kotlin 491

@shortcuts shortcuts marked this pull request as ready for review August 30, 2024 12:07
@shortcuts shortcuts requested a review from a team as a code owner August 30, 2024 12:07
@shortcuts
Copy link
Member Author

ok nvm I've broke everything

@shortcuts shortcuts marked this pull request as draft August 30, 2024 12:14
@shortcuts shortcuts marked this pull request as ready for review August 30, 2024 12:26
@shortcuts shortcuts changed the title fix(clients): usage hosts fix(clients): correly parse usage hosts Aug 30, 2024
@shortcuts shortcuts mentioned this pull request Aug 30, 2024
Copy link

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks perfect !

@shortcuts shortcuts merged commit c0675ff into main Aug 30, 2024
26 checks passed
@shortcuts shortcuts deleted the fix/usage branch August 30, 2024 12:59
algolia-bot added a commit that referenced this pull request Aug 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Aug 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Aug 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Aug 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Aug 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Aug 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Aug 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Aug 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Aug 30, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Aug 30, 2024
millotp pushed a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Usage API client uses wrong API URL
3 participants