Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add v2 endpoints for ingestion #3416

Merged
merged 15 commits into from
Jul 25, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2663

Changes included:

Add the push endpoint to the specs

@shortcuts shortcuts self-assigned this Jul 25, 2024
@shortcuts shortcuts requested a review from a team as a code owner July 25, 2024 08:42
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 25, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 0139f885396d2600b92fc8134a545eae1f43543a
🍃 Generated commit df376e005d1efaf3cd25d4bd05b7e36530f6a0df
🌲 Generated branch generated/feat/ingestion-push-endpoint
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
javascript 1388
php 1328
csharp 1076
java 917
ruby 862
swift 739
python 719
go 454
kotlin 449

@shortcuts shortcuts marked this pull request as draft July 25, 2024 08:55
@shortcuts shortcuts marked this pull request as ready for review July 25, 2024 09:04
Copy link

github-actions bot commented Jul 25, 2024

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@@ -12,53 +12,13 @@ post:
- Actions are equivalent to the individual API requests of the same name.
parameters:
- $ref: '../../../common/parameters.yml#/IndexName'
x-codegen-request-body-name: batchWriteParams
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I thought so for the swift issue but it's a leftover indeed

@shortcuts shortcuts enabled auto-merge (squash) July 25, 2024 13:59
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg !

@shortcuts shortcuts merged commit 3ec5f5f into main Jul 25, 2024
21 checks passed
@shortcuts shortcuts deleted the feat/ingestion-push-endpoint branch July 25, 2024 15:35
algolia-bot added a commit that referenced this pull request Jul 25, 2024
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jul 25, 2024
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jul 25, 2024
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jul 25, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 25, 2024
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jul 25, 2024
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jul 25, 2024
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jul 25, 2024
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jul 25, 2024
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jul 25, 2024
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants