Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): exhaustiveFacetsCount is not deprecated for sffv #3089

Merged
merged 2 commits into from
May 16, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented May 16, 2024

🧭 What and Why

The exhaustiveFacetsCount property is considered deprecated in the Search response,
and users should rely on exhaustive.facetsCount instead.

The response from Search for facet values doesn't have an exhaustive object,
so exhaustiveFacetsCount can't be deprecated and we need to use different descriptions in both cases.

🎟 JIRA Ticket:

Changes included:

  • Don't reuse the definition of exhaustiveFacetsCount, but inline them for the Search and Search for facet values responses, not marking it deprecated in the Sffv response.

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 16, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link

@github-actions github-actions bot temporarily deployed to pull request May 16, 2024 09:52 Inactive
@kai687 kai687 marked this pull request as ready for review May 16, 2024 10:10
@kai687 kai687 requested a review from a team as a code owner May 16, 2024 10:10
@kai687 kai687 requested review from damcou and Fluf22 May 16, 2024 10:10
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ggreat catchhh

@shortcuts shortcuts merged commit 2b70d9e into main May 16, 2024
25 checks passed
@shortcuts shortcuts deleted the fix/not-deprecated branch May 16, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants