Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(swift): handle generics #2896

Merged
merged 8 commits into from
Mar 22, 2024
Merged

feat(swift): handle generics #2896

merged 8 commits into from
Mar 22, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Mar 21, 2024 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-1750

Changes included:

  • use generic types when possible

@Fluf22 Fluf22 self-assigned this Mar 21, 2024
@Fluf22 Fluf22 requested a review from a team as a code owner March 21, 2024 17:56
@Fluf22 Fluf22 requested review from damcou and millotp March 21, 2024 17:56
@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 21, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huuuge

clients/algoliasearch-client-swift/Sources/Search/Extra/SearchClientExtension.swift Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

🚀 Deployed on https://65fd8544430d3e007ccca530--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 21, 2024 18:41 Inactive
@Fluf22 Fluf22 requested a review from shortcuts March 21, 2024 18:46
@Fluf22
Copy link
Contributor Author

Fluf22 commented Mar 21, 2024

Wow, everything is green, there must be something wrong with the CI

@github-actions github-actions bot temporarily deployed to pull request March 21, 2024 19:03 Inactive
millotp
millotp previously approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks perfect gg ! small nit

generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java Outdated Show resolved Hide resolved
@Fluf22 Fluf22 requested a review from millotp March 22, 2024 13:06
@github-actions github-actions bot temporarily deployed to pull request March 22, 2024 13:19 Inactive
@Fluf22 Fluf22 merged commit dc92daa into main Mar 22, 2024
25 checks passed
@Fluf22 Fluf22 deleted the feat/swift-handle-generics branch March 22, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@shortcuts shortcuts Awaiting requested review from shortcuts

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fluf22 @algolia-bot @millotp @shortcuts