Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swift): remaining helpers #2758

Merged
merged 7 commits into from
Feb 22, 2024
Merged

feat(swift): remaining helpers #2758

merged 7 commits into from
Feb 22, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Feb 21, 2024

🧭 What and Why

🎟 JIRA Ticket: DI-1746

Changes included:

  • browseObjects
  • browseRules
  • browseSynonyms
  • searchForHits
  • searchForFacets

🧪 Test

Added handwritten tests for each helper

@Fluf22 Fluf22 self-assigned this Feb 21, 2024
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 5842ce1
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65d72f5581c8e90008880633
😎 Deploy Preview https://deploy-preview-2758--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 21, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Fluf22 Fluf22 force-pushed the feat/swift-manual-helpers branch 2 times, most recently from caff605 to 783ed6f Compare February 22, 2024 10:09
@Fluf22 Fluf22 marked this pull request as ready for review February 22, 2024 12:47
@Fluf22 Fluf22 requested a review from a team as a code owner February 22, 2024 12:47
Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a lot to say. It's realllly good job here !

templates/swift/tests/Package.mustache Show resolved Hide resolved
@Fluf22 Fluf22 merged commit fc4be59 into main Feb 22, 2024
14 checks passed
@Fluf22 Fluf22 deleted the feat/swift-manual-helpers branch February 22, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants