fix(specs): update shopify feature flags (#3380)

algolia · Jul 18, 2024 · 2800371 · 2800371
1 parent 53be992
commit 2800371
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 48 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -431,7 +431,7 @@ jobs:
           type: minimal
           language: swift
 
-      - run: yarn cli cts run swift ${{ fromJSON(needs.setup.outputs.SWIFT_DATA).toRun }}
+      - run: yarn cli cts run swift ${{ fromJSON(needs.setup.outputs.SWIFT_DATA).toRun }} -v
 
       - name: Set output
         id: setoutput

diff --git a/scripts/cts/runCts.ts b/scripts/cts/runCts.ts
@@ -115,7 +115,7 @@ async function runCtsOne(
       break;
     case 'swift':
       await run(
-        `swift test -Xswiftc -suppress-warnings -q --parallel ${filter((f) => `--filter ${f}.*`)}`,
+        `swift test -Xswiftc -suppress-warnings -v --parallel ${filter((f) => `--filter ${f}.*`)}`,
         {
           cwd,
           language,

diff --git a/specs/ingestion/common/schemas/source.yml b/specs/ingestion/common/schemas/source.yml
@@ -457,52 +457,10 @@ SourceUpdateShopify:
   type: object
   additionalProperties: false
   properties:
-    collectionIDIndexing:
-      type: boolean
-      default: false
-      description: |
-        Whether to index collection IDs. 
-        
-        If your store has `has_collection_search_page` set to true,
-        collection IDs will be indexed even if `collectionIDIndexing` is false. 
-    increaseProductCollectionLimit:
-      type: boolean
-      default: false
-      description: |
-        Whether to increase the number of indexed collections per product.
-        If true, Algolia indexes 200 collections per product.
-        If false, 100 collections per product are indexed.
-    defaultPriceRatioAsOne:
-      type: boolean
-      default: true
-      description: |
-        Whether to set the default price ratio to 1 if no sale price is present.
-        
-        The price ratio is determined by the ratio: `sale_price` / `regular_price`.
-        If no sale price is present, the price ratio would be 0.
-        If `defaultPriceRatioAsOne` is true, the price ratio is indexed as 1 instead.
-    excludeOOSVariantsForPriceAtTRS:
-      type: boolean
-      default: true
-      description: |
-        Whether to exclude out-of-stock variants when determining the `max_variant_price` and `min_variant_price` attributes.
-    includeVariantsInventory:
-      type: boolean
-      default: true
-      description: |
-        Whether to include an inventory with every variant for every product record.
-    hasCollectionSearchPage:
-      type: boolean
-      default: false
-      description: |
-        Whether to include collection IDs and handles in the product records.
-    productNamedTags:
-      type: boolean
-      default: false
-      description: |
-        Whether to convert tags on products to named tags.
-        
-        To learn more, see [Named tags](https://www.algolia.com/doc/integration/shopify/sending-and-managing-data/named-tags).
+    featureFlags:
+      type: object
+      description: Feature flags for the Shopify source.
+      additionalProperties: true
 
 SourceShopify:
   allOf: