Fix amount output when minority more then 100 #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Не знаю как у вас) но конструкция `Math.log(1000) / Math.LN10` от 1000 выдаст `2.99999999996` Отсюда кажется конструкция в целом оверхедом...почему бы просто не взять .log10 от числа
SiebenSieben
approved these changes
Apr 18, 2018
|
@romanlex https://developer.mozilla.org/ru/docs/Web/JavaScript/Reference/Global_Objects/Math/log10 |
stepancar
previously requested changes
Apr 21, 2018
|
wow, благодарю...упустил из виду, обновил |
SiebenSieben
approved these changes
May 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Не знаю как у вас)
но конструкция
Math.log(1000) / Math.LN10от 1000 выдаст2.99999999996Отсюда кажется конструкция в целом оверхедом...почему бы просто не взять .log10 от числа